chore/COMPASS-9709 add sync to compass script#113
Merged
Conversation
| }), | ||
| ); | ||
|
|
||
| console.log({ packageDir, srcDir, libDir, destDir }); |
Member
Author
There was a problem hiding this comment.
I found it a bit useful as a way to double check what was changed. Happy to remove it if you find it to be some extra noise.
| 1_000, | ||
| { | ||
| leading: true, | ||
| trailing: true, |
Member
Author
There was a problem hiding this comment.
It's a bit quicker when updating one file and then also covers when updating a lot quickly. If we find it refreshing Compass twice we can move it to only be trailing, I'm thinking let's keep an eye on it.
Member
Author
|
@lchans Going to merge this, happy to make any follow ups on suggestions or changes you might have. |
Contributor
|
Thanks @Anemy - Looks fine to me, feel free to add me or @adrianhhong to any of the reviews so it pops up on our radar! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External Links
Description
Adds a script that listens for changes in the diagramming package, builds it, and updates the local Compass node_modules of the diagramming package with the build. This is useful for testing out changes in Compass and making sure they behave as expected.
Requires mongodb-js/compass#7206 in Compass to hot reload.